Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GECKO 3.2.2 #388

Merged
merged 3 commits into from
Oct 15, 2024
Merged

GECKO 3.2.2 #388

merged 3 commits into from
Oct 15, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jul 31, 2024

  • Features:
    • If sensitivityTuning modifies a kcat value, it will now be indicated in model.ec.source as 'sensitivityTuning', and the previous kcat value and source will be kept in the model.ec.notes field as preTuneKcat=*value* | source:*original source*. If the kcat value had been subjected to senstivityTuning before, then the notes field will remain unchanged, so repeated runs of sensitivityTuning will not overwrite the notes.
    • runDLKcat support alternative paths and names of the DLKcat.tsv file (solves runDLKcat(): use DLKcat.tsv in a different directory #392) .
  • Fix:
    • By default, the obj.params.uniprot.reviewed parameter in the adapterTemplate is set to false, to increase the number of matching proteins.
    • The model.ec.source entry after running setKcatForReactions has been corrected to 'setKcatForReactions'.
  • Documentation:

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

* doc: README.md MATLAB badge

* fix: setKcatForReactions correct source field

* feat: sensitivityTuning note of preTuneKcat

* doc: adapterTemplate set reviewed to false

by default allow for more uniprot protein matches

* fix: update tutorial ecYeastGEM.yml

* doc: clarify params.enzyme_comp in model adapter
Copy link

github-actions bot commented Jul 31, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
GECKO version 3.2.1 installed
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

* fix: compatible with next RAVEN release

* fix: rename anaerobicModel

A yeast-GEM-specific script that ideally should be refactored. For now, just rename to avoid conflict with the function in yeast-GEM repository
* feat: alternative path of DLKcat in/output

* fix: avoid double output with printOrange function

* fix: remove mentions of Gitter

* doc: makeEcModel informative error noUniprof

* fix: check RAVEN version
@edkerk edkerk merged commit 939fe68 into main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant